RFR: JDK-8293313: NMT: Rework MallocLimit [v4]

Gerard Ziemski gziemski at openjdk.org
Thu Jan 26 17:28:23 UTC 2023


On Wed, 25 Jan 2023 06:24:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 1344:
>> 
>>> 1342:           "Number of exits until ZombieALot kicks in")                      \
>>> 1343:                                                                             \
>>> 1344:   product(ccstr, MallocLimit, nullptr, DIAGNOSTIC,                          \
>> 
>> Pre-existing, but I wish this flag was named `NMTMallocLimit`, not `MallocLimit`.
>
> I prefer MallocLimit, short and snappy. And the fact that NMT is supervising the limit is an implementation detail. It used to be different with MallocMaxTestWords and may be different in the future.

Still, you named the test file `test/hotspot/gtest/nmt/test_nmt_malloclimit.cpp`, not `test/hotspot/gtest/nmt/test_malloclimit.cpp` :-)

-------------

PR: https://git.openjdk.org/jdk/pull/11371


More information about the hotspot-dev mailing list