RFR: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler [v3]
Feilong Jiang
fjiang at openjdk.org
Fri Jan 27 03:34:20 UTC 2023
On Fri, 27 Jan 2023 02:38:59 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> On RISC-V, functions baseOffset & baseOffset32 from MacroAssembler receive an Address in base_plus_offset mode. These two functions check the range of the offset, add it and base and put the result in a destination register. This duplicates function MacroAssembler::la in functionality. We could refactor this part moving the logic of Address legitimization into MacroAssembler::la and use this function instead.
>>
>> Testing:
>> - [x] Bootcycle (release & fastdebug)
>> - [x] Tier1-4 (release)
>> - [x] Benchmarks: SPECjbb2015 (release)
>
> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Fix
> - Merge branch 'master' into JDK-8301036
> - Comment
> - Merge branch 'master' into JDK-8301036
> - 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
Marked as reviewed by fjiang (Author).
-------------
PR: https://git.openjdk.org/jdk/pull/12177
More information about the hotspot-dev
mailing list