RFR: 8300463: Build failure on Windows 32 after JDK-8296401
Kim Barrett
kbarrett at openjdk.org
Fri Jan 27 10:42:17 UTC 2023
On Wed, 25 Jan 2023 05:43:52 GMT, Fei Yang <fyang at openjdk.org> wrote:
> This issue also triggers when building slowdebug on linux-aarch64 with GCC-9.4.0. Given that std::numeric_limits<int>::max() returns positive integer number and size_t is an unsigned type, I guess it's safe to do simple static_cast here both on 32-bit and 64-bit platfoms. Slowdebug on linux-aarch64 builds fine with this fix.
src/hotspot/share/utilities/concurrentHashTable.inline.hpp line 1000:
> 998: ndel[dels] = rem_n;
> 999: } else {
> 1000: guarantee(dels < static_cast<size_t>(std::numeric_limits<int>::max()),
Does the problem go away if this uses `INT_MAX` instead?
-------------
PR: https://git.openjdk.org/jdk/pull/12178
More information about the hotspot-dev
mailing list