RFR: 8301136: Improve unlink() and unlink_all() of ResourceHashtableBase [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Jan 27 13:49:25 UTC 2023


On Fri, 27 Jan 2023 13:45:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a template for unlink(), unlink_all() and dtor.
>
> src/hotspot/share/utilities/resourceHash.hpp line 282:
> 
>> 280:   template<class ITER>
>> 281:   void unlink(ITER* iter) {
>> 282:     auto wrapper = [&](Node* const node, Node**& ptr) {
> 
> I wanted unlink to be lambda enabled, not an unlink_impl.  Can you just make unlink_all be something that provides a "return true" lambda and call unlink with that?

Or rather, first have a patch to add  unlink that takes a lambda and convert the uses to that.  I don't see the motivation for this change.

-------------

PR: https://git.openjdk.org/jdk/pull/12213


More information about the hotspot-dev mailing list