RFR: JDK-8301224: Replace NULL with nullptr in share/gc/shared/

[Johan Sjölen]

On Fri, 27 Jan 2023 10:06:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/gc/shared/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Found only one issue.

src/hotspot/share/gc/shared/c2/barrierSetC2.cpp line 366:

> 364:     Node* adr = _addr.node();
> 365:     if (!needs_cpu_membar() && adr_type->isa_instptr()) {
> 366:       assert(adr_type->meet(TypePtr::nullptr_PTR) != adr_type->remove_speculative(), "should be not null");

NULL_PTR

-------------

PR: https://git.openjdk.org/jdk/pull/12249