RFR: 8301244: Replace legacy pragma implementations in HotSpot's compilerWarnings.hpp [v7]

Julian Waters jwaters at openjdk.org
Sun Jan 29 06:52:21 UTC 2023


On Sat, 28 Jan 2023 12:30:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   compilerWarnings_gcc.hpp
>
> src/hotspot/share/utilities/macros.hpp line 33:
> 
>> 31: // For when Pragmas need to be reliably nested in macros. Also handles
>> 32: // quotation marks, so use sites are not required to pass string literals
>> 33: #define PRAGMA(str) _Pragma(#str)
> 
> This shouldn't be here.  A file could include only compilerWarnings.hpp and not this file, and not be able to use pragma macros provided by compilerWarnings.hpp.

@kimbarrett compilerWarnings.hpp does include macros.hpp before the compiler specific macros, so this shouldn't be an issue

-------------

PR: https://git.openjdk.org/jdk/pull/12255


More information about the hotspot-dev mailing list