Integrated: 8301088: oopDesc::print_on should consistently use a trailing newline
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon Jan 30 07:17:23 UTC 2023
On Wed, 25 Jan 2023 13:56:08 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161) added special printing when `oopDesc` contains `badHeapWordVal` or `badMetaWordVal`. However these two cases do not print a trailing newline. The previous behaviour was to always use a trailing newline.
>
> Propose making this consistent with `*klass::oop_print_on` and `InstanceStackChunkKlass::print_chunk`, that both uses a trailing newline.
>
> This new behaviour messes up some printing code, e.g. can be seen in print_location when printing hs_err files which assumes that it always prints a trailing newline.
This pull request has now been integrated.
Changeset: 4bd3f0a0
Author: Axel Boldt-Christmas <aboldtch at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/4bd3f0a0d5f0ad314cd4e7a68851c2db9100df67
Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
8301088: oopDesc::print_on should consistently use a trailing newline
Reviewed-by: tschatzl, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/12195
More information about the hotspot-dev
mailing list