Integrated: 8301248: Less side effects in InstanceRefKlass::trace_reference_gc

Erik Österlund eosterlund at openjdk.org
Mon Jan 30 10:33:24 UTC 2023


On Fri, 27 Jan 2023 15:42:05 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> The InstanceRefKlass::trace_reference_gc function is called when using oop_iterate on a reference object. Since oop_iterate is a general iterator that can be used for anything, including verification code, it would be desirable for this code to not have subtle side effects. We currently apply load barriers which "fix" pointers in the heap. As a result, verification code that was meant to detect bugs, can end up fixing and hiding the bug. This CR aims to address this by limiting the logging to addresses, and not following them.

This pull request has now been integrated.

Changeset: c672ed16
Author:    Erik Österlund <eosterlund at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c672ed16f363d9c92ccefe2e64a96e0a60a49588
Stats:     18 lines in 1 file changed: 6 ins; 2 del; 10 mod

8301248: Less side effects in InstanceRefKlass::trace_reference_gc

Co-authored-by: Stefan Karlsson <stefank at openjdk.org>
Co-authored-by: Axel Boldt-Christmas <aboldtch at openjdk.org>
Reviewed-by: rkennke, stefank

-------------

PR: https://git.openjdk.org/jdk/pull/12258


More information about the hotspot-dev mailing list