RFR: 8301244: Replace legacy pragma implementations in HotSpot's compilerWarnings.hpp [v7]
David Holmes
dholmes at openjdk.org
Tue Jan 31 00:52:58 UTC 2023
On Sun, 29 Jan 2023 06:38:19 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> HotSpot has a few legacy implementations of pragmas in some of its macros in compilerWarnings.hpp, they should be cleaned up and use a more modern approach. Rename PRAGMA macro in compilerWarnings_gcc.hpp as well since it can be used for more than just compiler warnings
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> compilerWarnings_gcc.hpp
Is the intent here to allow `PRAGMA_UTIL` to be used in other code to add pragmas? I'm not seeing how that could work as they would still be compiler specific and if the use is ifdef'd then you don't need the `PRAGMA_UTIL` macro (not a great name).
-------------
PR: https://git.openjdk.org/jdk/pull/12255
More information about the hotspot-dev
mailing list