RFR: 8294402: Add diagnostic logging to VMProps.checkDockerSupport [v2]

Mikhailo Seledtsov mseledtsov at openjdk.org
Tue Jan 31 01:07:13 UTC 2023


On Tue, 31 Jan 2023 00:11:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Comment about logging to stdout
>>  - Conditionally enable VMProps logging
>
> test/jtreg-ext/requires/VMProps.java line 659:
> 
>> 657:     protected static void log(String msg) {
>> 658:         // By jtreg design stderr produced here will be visible
>> 659:         // in the output of a parent process.
> 
> Suggest extending the comment:
> 
> // in the output of a parent process. stdout should not be used for logging as jtreg parses that output directly
> // and only echoes it in the event of a failure.

Thanks. Will update the comment.

-------------

PR: https://git.openjdk.org/jdk/pull/12239


More information about the hotspot-dev mailing list