RFR: JDK-8301354: Modernize utilities/breakpoint.hpp [v4]

[David Holmes]

On Mon, 30 Jan 2023 17:09:23 GMT, Justin King <jcking at openjdk.org> wrote:

>> Cleanup `utilities/breakpoint.hpp` by utilizing compiler intrinsics when available, or normal signals for AIX/XLC.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix reference to unqualified breakpoint
>   
>   Signed-off-by: Justin King <jcking at google.com>

So you are turning something currently OS-specific into something toolchain specific, and I'm not sure that is really correct, or even necessary.

src/hotspot/share/utilities/breakpoint.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Google and/or its affiliates. All rights reserved.

Please restore the Oracle copyright with second year updated to 2023. Thanks.

src/hotspot/share/utilities/breakpoint.hpp line 60:

> 58: #define BREAKPOINT ::raise(SIGTRAP)
> 59: 
> 60: #elif defined(SIGINT)

The VM already uses SIGINT to shutdown the VM - raising it here doesn't seem right.

-------------

PR: https://git.openjdk.org/jdk/pull/12296