RFR: JDK-8301481: Replace NULL with nullptr in os/windows

Johan Sjölen jsjolen at openjdk.org
Tue Jan 31 11:39:42 UTC 2023


Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory os/windows. Unfortunately the script that does the change isn't perfect, and so we
need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.

Here are some typical things to look out for:

1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.

An example of this:

```c++
// This function returns null
void* ret_null();
// This function returns true if *x == nullptr
bool is_nullptr(void** x);


Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.

Thanks!

-------------

Commit messages:
 - Merge branch 'master' into JDK-8301481
 - Fixes
 -  Replace NULL with nullptr in os/windows

Changes: https://git.openjdk.org/jdk/pull/12317/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12317&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301481
  Stats: 652 lines in 21 files changed: 0 ins; 0 del; 652 mod
  Patch: https://git.openjdk.org/jdk/pull/12317.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12317/head:pull/12317

PR: https://git.openjdk.org/jdk/pull/12317


More information about the hotspot-dev mailing list