RFR: 8310656: RISC-V: __builtin___clear_cache can fail silently. [v2]

Robbin Ehn rehn at openjdk.org
Sat Jul 1 11:11:18 UTC 2023


On Sat, 1 Jul 2023 00:22:19 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added back data barrier
>>   
>>   Signed-off-by: Robbin Ehn <rehn at rivosinc.com>
>
> src/hotspot/cpu/riscv/icache_riscv.cpp line 49:
> 
>> 47: 
>> 48: void ICacheStubGenerator::generate_icache_flush(ICache::flush_icache_stub_t* flush_icache_stub) {
>> 49:   // Only riscv_flush_icache is supported as I-cache synhronization.
> 
> Typo: s/synhronization/synchronization/

Fixed, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14670#discussion_r1248772314


More information about the hotspot-dev mailing list