Integrated: 8310656: RISC-V: __builtin___clear_cache can fail silently.
Robbin Ehn
rehn at openjdk.org
Sun Jul 2 16:18:09 UTC 2023
On Tue, 27 Jun 2023 08:19:47 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Hi, please consider.
>
> We recently had a bug where user were missing permissions to use this syscall.
> Which caused crashing on, according to hs_err on things like "addi x11, x24, 0" with SIGILL.
> If it fails it is even possible to execute valid but 'old' instruction which may not lead to a crash, instead the program misbehaves.
>
> To avoid this mess I suggest that we first test the syscall during vm init and we use it directly.
> This way we can make sure it never fails.
>
> Tested failing syscall with qemu, tested t1 in qemu, t1 on jh7110 in-progress.
This pull request has now been integrated.
Changeset: faf1b822
Author: Robbin Ehn <rehn at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/faf1b822d03b726413d77a2b247dfbbf4db7d57e
Stats: 121 lines in 3 files changed: 116 ins; 1 del; 4 mod
8310656: RISC-V: __builtin___clear_cache can fail silently.
Reviewed-by: luhenry, stuefe, fyang
-------------
PR: https://git.openjdk.org/jdk/pull/14670
More information about the hotspot-dev
mailing list