RFR: 8311180: Remove unused unneeded definitions from globalDefinitions [v2]

David Holmes dholmes at openjdk.org
Mon Jul 3 01:49:55 UTC 2023


On Sat, 1 Jul 2023 15:03:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi Thomas, thanks for noticing.  I messed this one up.
>> 
>> Are you arguing for address_word to avoid this confusion?  That's a lot of reeducation in the code.
>
> Hi Coleen, no, I was just wondering if the decision was deliberate. I may have overlooked a reason for this.

@tstuefe  `p2i()` is mainly used for printing, and the format uses hex so the signed-ness is immaterial. But in general, yes this seems an odd choice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14737#discussion_r1250018263


More information about the hotspot-dev mailing list