RFR: JDK-8310233: Linux: THP initialization is incorrect [v2]

[Thomas Stuefe]

On Mon, 3 Jul 2023 10:16:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8310233-Linux-THP-initialization-incorrect' of github.com:tstuefe/jdk into JDK-8310233-Linux-THP-initialization-incorrect
>>  - Add test case and modify log output slightly
>
> Hi Thomas,
> 
> Thanks for these changes. I've some suggestions for the code, but the conceptual change is good.

@jdksjolen Thanks a lot for your review!

See inline remarks. Most of your code suggestions are good, but this patch just moved the static hugepage detection parts out of os_linux.cpp, and left them (mostly) alone otherwise, to avoid adding regressions. I'll keep your input in mind for the next round of cleanups.

Wrt NonInterleavingLogStream, I decided to not do that. It is not needed, since we are single-threaded, and it without it I may still be lucky to get it integrated cleanly to at least 17.

I added a new repro case. Please take a look!

Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14739#issuecomment-1618333548