RFR: 8139457: Array bases are aligned at HeapWord granularity [v38]
Aleksey Shipilev
shade at openjdk.org
Mon Jul 3 18:00:29 UTC 2023
On Mon, 3 Jul 2023 17:09:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Build fixes
>
> src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp line 44:
>
>> 42: // successful thread-local allocation
>> 43: #ifdef ASSERT
>> 44: Copy::fill_to_words(obj, size, badHeapWordVal);
>
> So, this is safe after CMS removal, or for some other reason? I think this and other two removals near `Skip mangling the space corresponding to the object header` comment should be done in a separate PR to avoid cluttering this one.
https://github.com/openjdk/jdk/commit/0917ad432eb3d01c104f03973c5c7ff52c6dfefe suggests skipping the header during the zapping was added for G1. So why it is safe to remove?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/11044#discussion_r1251156072
More information about the hotspot-dev
mailing list