RFR: 8139457: Array bases are aligned at HeapWord granularity [v38]

Roman Kennke rkennke at openjdk.org
Tue Jul 4 07:28:12 UTC 2023


On Mon, 3 Jul 2023 17:29:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Build fixes
>
> src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp line 343:
> 
>> 341:     JVMFlag::printError(verbose,
>> 342:                         "MinTLABSize (" SIZE_FORMAT " bytes) must be "
>> 343:                         "less than or equal to ergonomic TLAB maximum (" SIZE_FORMAT " words)\n",
> 
> Wait, let's not mix "bytes" and "words" in the same message. Users do not readily know what is the HeapWordSize on the machine, or even how bytes and words might be related.
> 
> Is there a reason to even change these? Does the original code overflow?

Yeah, IIRC I changed this to deal with overflow (on 32-bit)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11044#discussion_r1251608169


More information about the hotspot-dev mailing list