RFR: JDK-8310233: Linux: THP initialization is incorrect [v2]
Thomas Stuefe
stuefe at openjdk.org
Tue Jul 4 12:46:00 UTC 2023
On Tue, 4 Jul 2023 11:47:54 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge branch 'JDK-8310233-Linux-THP-initialization-incorrect' of github.com:tstuefe/jdk into JDK-8310233-Linux-THP-initialization-incorrect
>> - Add test case and modify log output slightly
>
> test/hotspot/jtreg/runtime/os/HugePageConfiguration.java line 92:
>
>> 90: Scanner scanner;
>> 91: try {
>> 92: scanner = new Scanner(new File("/proc/meminfo"));
>
> Nit: You can use try-with-resources here.
Makes sense
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14739#discussion_r1251981584
More information about the hotspot-dev
mailing list