RFR: 8193513: add support for printing a stack trace on class loading [v4]

[David Holmes]

On Tue, 4 Jul 2023 07:06:17 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>>> The test uses -Xlog:all=trace:file=all.log so will indiscriminately log class+load+cause+native for every class loaded and the test seems to load a lot of classes.
>> 
>> Are you treating not setting `LogClassLoadingCauseFor` as being a wildcard for "all"? That's not what you had earlier and seems wrong - this needs to be opt-in.
>> 
>>> The test crashes the VM as VMError::print_native_stack is apparently not safe to call in all class loading contexts.
>> 
>> That is a distinct bug in itself. Probably print_native_stack needs additional safety/state checks. I will file a bug for that.
>> 
>> Edit: filed [JDK-8311255](https://bugs.openjdk.org/browse/JDK-8311255)
>
>> Are you treating not setting LogClassLoadingCauseFor as being a wildcard for "all"? That's not what you had earlier and seems wrong - this needs to be opt-in.
> 
> Done: 24f8539a780aa6f6284c0fd7d4eee34d416cb544

> @dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. 

Yes @dougxc please do not do this. There is no need, skara will flatten the final commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14553#issuecomment-1620906870