RFR: 8193513: add support for printing a stack trace on class loading [v7]

[David Holmes]

On Wed, 5 Jul 2023 02:11:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   use OS specific native stack printing in class load cause native stack logging
>
> src/hotspot/share/oops/instanceKlass.cpp line 3867:
> 
>> 3865:         // We have printed the native stack in platform-specific code,
>> 3866:         // so nothing else to do in this case.
>> 3867:       } else {
> 
> Why did you do this? Did you observe problems on Windows? This is too low-level for this code. If we need to do this then it needs to be pushed down to a lower-level and encapsulated more cleanly. We do not do this in `JavaThread::print_jni_stack()`.
> 
> I need to revoke my approval while this is resolved.

I'm also investigating the details of the stack printing code - use of `os::platform_print_native_stack` is very inconsistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14553#discussion_r1252619122