RFR: 8301996: Move field resolution information out of the cpCache [v2]

Martin Doerr mdoerr at openjdk.org
Wed Jul 5 09:32:57 UTC 2023


On Thu, 29 Jun 2023 15:44:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Coleen and Amit comments

src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2538:

> 2536:   load_resolved_field_entry(obj, cache, index, off, raw_flags, is_static);
> 2537:   // Index holds the TOS
> 2538:   __ mov(flags, index);

This is very confusing. You call the same thing "TOS", "type" and "index". Please use consistent naming and make it more comprehensive. In addition, why do you need the extra move?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1252826981


More information about the hotspot-dev mailing list