RFR: 8301996: Move field resolution information out of the cpCache [v2]

[Matias Saavedra Silva]

On Wed, 5 Jul 2023 09:30:08 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Coleen and Amit comments
>
> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2538:
> 
>> 2536:   load_resolved_field_entry(obj, cache, index, off, raw_flags, is_static);
>> 2537:   // Index holds the TOS
>> 2538:   __ mov(flags, index);
> 
> This is very confusing. You call the same thing "TOS", "type" and "index". Please use consistent naming and make it more comprehensive. In addition, why do you need the extra move?

Great point, this is very unclear. I will use better names which should remove the need for any moves.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1253440770