RFR: 8301996: Move field resolution information out of the cpCache [v2]

Wed Jul 5 20:23:57 UTC 2023

On Fri, 30 Jun 2023 14:40:34 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2553:
>> 
>>> 2551:   if (!CompilerConfig::is_c1_or_interpreter_only_no_jvmci()){
>>> 2552:     Label notVolatile;
>>> 2553:     __ andr(raw_flags, raw_flags, 0x1);
>> 
>> It looks like `andr` is not needed here?
>
> I believe `andr` is still necessary here since `raw_flags` has two bits that are used. The is_volatile flag may be false but if is_final is true, the flag will not be zero without the and.

It looks like I misunderstood what `tbz` does! I believe you are correct in suggesting that the `andr` is not necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1253605354