RFR: 8311575: Fix invalid format parameters
David Holmes
dholmes at openjdk.org
Fri Jul 7 04:09:54 UTC 2023
On Thu, 6 Jul 2023 11:25:11 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Please review this change that fixes a few issues with printf-like function parameters.
>
> No new tests. I'll run tier1 & tier2 before integrating, just to make sure.
Looks good - thanks for fixing. One suggested further fix.
src/hotspot/share/runtime/arguments.cpp line 3951:
> 3949: if (lvl == NMT_unknown) {
> 3950: jio_fprintf(defaultStream::error_stream(),
> 3951: "Syntax error, expecting -XX:NativeMemoryTracking=[off|summary|detail]");
I think it also needs a trailing `\n`
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14783#pullrequestreview-1517740505
PR Review Comment: https://git.openjdk.org/jdk/pull/14783#discussion_r1255220735
More information about the hotspot-dev
mailing list