RFR: 8311604: Simplify NOCOOPS requested addresses for archived heap objects [v3]

Ioi Lam iklam at openjdk.org
Sat Jul 8 00:25:24 UTC 2023


On Fri, 7 Jul 2023 22:27:27 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - @calvinccheung review: print heap_roots_offset
>>  - @calvinccheung review: fixed include guard in headers; fixed misaligned line escapes in cds_globals.hpp
>
> src/hotspot/share/cds/filemap.cpp line 290:
> 
>> 288:   st->print_cr("- serialized_data_offset:         " SIZE_FORMAT_X, _serialized_data_offset);
>> 289:   st->print_cr("- heap_begin:                     " INTPTR_FORMAT, p2i(_heap_begin));
>> 290:   st->print_cr("- heap_end:                       " INTPTR_FORMAT, p2i(_heap_end));
> 
> Maybe print the _heap_roots_offset?

Hi Calvin, thanks for the review. I added the `_heap_roots_offset` into the debug output.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14792#discussion_r1256647933


More information about the hotspot-dev mailing list