RFR: 8311604: Simplify NOCOOPS requested addresses for archived heap objects

[Ioi Lam]

On Fri, 7 Jul 2023 15:12:08 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> This PR attempts to clean up some of the cruds in the existing code:
>> 
>> - Simplified the calculation of "requested address" when `UseCompressedOops` is disabled -- the archived heap objects are always written starting from 0x10000000
>> - Removed `HeapShared::to_requested_address()` so we don't have two kinds of "requested address"
>> - Updated the comments about "source" vs "buffered" vs "requested" addresses in archiveHeapWriter.hpp
>> - Removed `SerializeClosure::oop()` as the only oop we need to store into the archive header is `HeapShared::roots()`, which can be handled more easily with `FileMapHeader::_heap_roots_offset`
>> - Removed some unnecessary dependencies on `G1CollectedHeap::heap()->reserved()`
>> 
>> Also:
>> - Moved SerializeClosure to its own header file to improve build time.
>> - Fixed DeterministicDump.java, which wasn't archiving Java objects when  `UseCompressedOops` was disabled.
>
> minor nitpicks, otherwise looks good!

Thanks @ashu-mehra and @calvinccheung for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14792#issuecomment-1627744432