Integrated: 8311604: Simplify NOCOOPS requested addresses for archived heap objects

Ioi Lam iklam at openjdk.org
Sun Jul 9 15:21:17 UTC 2023


On Thu, 6 Jul 2023 23:39:34 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This PR attempts to clean up some of the cruds in the existing code:
> 
> - Simplified the calculation of "requested address" when `UseCompressedOops` is disabled -- the archived heap objects are always written starting from 0x10000000
> - Removed `HeapShared::to_requested_address()` so we don't have two kinds of "requested address"
> - Updated the comments about "source" vs "buffered" vs "requested" addresses in archiveHeapWriter.hpp
> - Removed `SerializeClosure::oop()` as the only oop we need to store into the archive header is `HeapShared::roots()`, which can be handled more easily with `FileMapHeader::_heap_roots_offset`
> - Removed some unnecessary dependencies on `G1CollectedHeap::heap()->reserved()`
> 
> Also:
> - Moved SerializeClosure to its own header file to improve build time.
> - Fixed DeterministicDump.java, which wasn't archiving Java objects when  `UseCompressedOops` was disabled.

This pull request has now been integrated.

Changeset: 581f90e2
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/581f90e242b8a943215a223189d171b7ede37785
Stats:     403 lines in 30 files changed: 159 ins; 172 del; 72 mod

8311604: Simplify NOCOOPS requested addresses for archived heap objects

Reviewed-by: ccheung

-------------

PR: https://git.openjdk.org/jdk/pull/14792


More information about the hotspot-dev mailing list