RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Jul 11 01:37:27 UTC 2023


On Mon, 10 Jul 2023 16:40:06 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Move StringTable to JavaClassFile namespace.
>
> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8311661
>  - Move  '} // namespace JavaClassFile' to after '#endif //INCLUDE_CDS_JAVA_HEAP'.
>  - 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking

Ok, yeah, I'd hate for Thread to get a namespace:: prepended to the million uses of it.  Maybe the same approach should be used for StringTable too, since they're solving the same problem.  Is there an #if STATIC_LINK or something that surrounds this #define?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14808#issuecomment-1629965664


More information about the hotspot-dev mailing list