RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v2]

[Coleen Phillimore]

On Mon, 10 Jul 2023 16:40:06 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Move StringTable to JavaClassFile namespace.
>
> Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8311661
>  - Move  '} // namespace JavaClassFile' to after '#endif //INCLUDE_CDS_JAVA_HEAP'.
>  - 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking

When you add in Thread, the namespace solution seems a lot less attractive unless you can do "using namespace hotspot;" around all the code in the JVM without altering names everywhere.  Having sets of different HotSpotX namespaces seems a lot less attractive in the code and isn't really more general.  So I don't think this is a good change anymore.

Maybe there is a build option to wrap names as Ioi suggested or some global namespace wrapping.  But then we'd just want to wrap the whole thing in namespace hotspot.  This code was written before namespaces existed everywhere.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14808#issuecomment-1631038577