RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers

Andrew Haley aph at openjdk.org
Tue Jul 11 16:37:04 UTC 2023


On Tue, 11 Jul 2023 14:58:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I'll try this suggestion.
>
> src/hotspot/cpu/aarch64/nativeInst_aarch64.hpp:614:35: error: call to 'patch' is ambiguous
> [2023-07-11T14:00:01,568Z]   void set_kind(int order_kind) { Instruction_aarch64::patch(addr_at(0), 11, 8, order_kind); }
> [2023-07-11T14:00:01,568Z]                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The compiler thinks its ambiguous.

I'm not surprised. I think that overloading `patch()` will be a trail of tears.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14822#discussion_r1259989146


More information about the hotspot-dev mailing list