RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Jul 12 00:43:54 UTC 2023


> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
> 
> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Fix narrow_cast in assembler to check for signed ranges when signed arguments are passed in.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14822/files
  - new: https://git.openjdk.org/jdk/pull/14822/files/08354ed5..12b1e95b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14822&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14822&range=00-01

  Stats: 10 lines in 4 files changed: 3 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/14822.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14822/head:pull/14822

PR: https://git.openjdk.org/jdk/pull/14822


More information about the hotspot-dev mailing list