RFR: 8307352: AARCH64: Improve itable_stub [v2]

Volker Simonis simonis at openjdk.org
Wed Jul 12 11:49:21 UTC 2023


On Mon, 10 Jul 2023 11:26:41 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Boris Ulasevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>> 
>>   8307352: AARCH64: Improve itable_stub
>
> src/hotspot/cpu/aarch64/vtableStubs_aarch64.cpp line 200:
> 
>> 198:                                   temp_reg, temp_reg2, temp_reg3, itable_index, L_no_such_interface);
>> 199: 
>> 200:   const ptrdiff_t lookupSize = __ pc() - start_pc;
> 
> I think you can rename `lookupSize` into `codesize`.

Agree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13792#discussion_r1261058060


More information about the hotspot-dev mailing list