RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v2]

Jiangli Zhou jiangli at openjdk.org
Wed Jul 12 23:10:56 UTC 2023


On Wed, 12 Jul 2023 01:26:08 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> Add `using <namespace>` to precompiled.hpp does help avoid adding `<namespace>::` in many places. We still need to put the implementation code inside `namespace <namespace> { ...}`, or use `<namespace>::`. I experimented with StringTable and only needed to edit stringTable.* and precompiled.hpp. I tested with and without `--disable-precompiled-headers` and both built ok.

src/hotspot/share/classfile/javaClasses.hpp also needs change, otherwise it fails to build on windows.

I updated the PR with suggestions incorporated. Please take a look of the updated version, thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14808#issuecomment-1633318213


More information about the hotspot-dev mailing list