RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v3]

Dean Long dlong at openjdk.org
Thu Jul 13 04:18:18 UTC 2023


On Wed, 12 Jul 2023 01:35:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
>> 
>> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Unset Wconversion

This seems more than adequate for removing -Wconversion warnings.

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14822#pullrequestreview-1527541944


More information about the hotspot-dev mailing list