RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v4]

[Andrew Haley]

On Wed, 12 Jul 2023 12:17:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
>> 
>> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation, thanks for pointing that out @aph.

Looks good, thanks. After all that back-and-forth I think you've come up with a clean and maintainable solution to a tricky problem.

-------------

Marked as reviewed by aph (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14822#pullrequestreview-1527904118