RFR: 8311946: add support for libgraal specific jtreg tests [v3]

Vladimir Kozlov kvn at openjdk.org
Thu Jul 13 16:50:13 UTC 2023


On Thu, 13 Jul 2023 09:48:24 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR adds support for `vm.libgraal` and `vm.libgraal.enabled` properties that can be used with the jtreg `@requires` tag to determine if a libgraal specific test should run.
>> 
>> * `vm.libgraal`: the libgraal shared library file is present
>> * `vm.libgraal.enabled`: libgraal is used as JIT compiler
>
> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - add support for vm.libgraal property and fix problems with vm.libgraal.enabled property
>  - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8311946
>  - fix wrong flag name
>  - add support for vm.libgraal.enabled property

test/jtreg-ext/requires/VMProps.java line 127:

> 125:         map.put("vm.graal.enabled", this::isGraalEnabled);
> 126:         // vm.libgraal is true if the libgraal shared library file is present
> 127:         map.put("vm.libgraal", this::hasLibraal);

May be the property also should be named "vm.hasLibgraal" to be clear what it means.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14851#discussion_r1262818055


More information about the hotspot-dev mailing list