RFR: 8311946: add support for libgraal specific jtreg tests [v3]
Doug Simon
dnsimon at openjdk.org
Thu Jul 13 19:22:11 UTC 2023
On Thu, 13 Jul 2023 18:52:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> I'm not so sure. The current naming seems consistent with other existing properties:
>>
>> map.put("vm.jvmti", this::vmHasJVMTI);
>> map.put("vm.jvmci", this::vmJvmci);
>>
>> However, I can change it if you insist.
>
> I would prefer naming similar to "vm.hasJFR", "vm.hasSA", "vm.hasDTrace". It is unfortunate that we used "vm.jvmci" and "vm.jvmti" naming to check presence of features.
>
> Also libgraal is not part of VM. May be you need to use "jdk.hasLibgraal". There are other properties which use "jdk." already.
Ok, `hasLibgraal` is fine.
In what sense is libgraal not part of the VM? I would have thought that a JIT compiler is more "vm" than "jdk"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14851#discussion_r1262967313
More information about the hotspot-dev
mailing list