RFR: 8193513: add support for printing a stack trace on class loading [v9]

Doug Simon dnsimon at openjdk.org
Thu Jul 13 21:29:25 UTC 2023


On Thu, 13 Jul 2023 21:12:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor body of print_class_load_logging in print_class_load_helper
>
> src/hotspot/share/oops/instanceKlass.cpp line 3835:
> 
>> 3833:                         cfs->length(),
>> 3834:                         ClassLoader::crc32(0, (const char*)cfs->buffer(),
>> 3835:                         cfs->length()));
> 
> The indentation changes you made here (and elsewhere) are incorrect - the original was correct: arguments should line up

Sorry about that. I'll piggy back a fix onto https://github.com/openjdk/jdk/pull/14851.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14553#discussion_r1263067992


More information about the hotspot-dev mailing list