RFR: 8311946: add support for libgraal specific jtreg tests [v4]

David Holmes dholmes at openjdk.org
Fri Jul 14 01:03:23 UTC 2023


On Thu, 13 Jul 2023 21:55:34 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR adds support for `jdk.hasLibgraal` and `vm.libgraal.enabled` properties that can be used with the jtreg `@requires` tag to determine if a libgraal specific test should run.
>> 
>> * `jdk.hasLibgraal`: the libgraal shared library file is present
>> * `vm.libgraal.enabled`: libgraal is used as JIT compiler
>
> Doug Simon has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - rename vm.hasLibgraal to jdk.hasLibgraal
>  - rename vm.libgraal to vm.hasLibgraal
>  - fix indentation

test/jtreg-ext/requires/VMProps.java line 498:

> 496:      * @return true if the libgraal shared library file is present.
> 497:      */
> 498:     protected String hasLibraal() {

Typo: 'g' is missing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14851#discussion_r1263172925


More information about the hotspot-dev mailing list