RFR: 8311661: Resolve duplicate symbol of StringTable::StringTable with JDK static linking [v4]
David Holmes
dholmes at openjdk.org
Fri Jul 14 02:50:15 UTC 2023
On Wed, 12 Jul 2023 19:29:31 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Move StringTable to 'hotspot_jvm' namespace.
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Add hotspot_jvm:: to StringTable in javaClasses.hpp.
I am concerned that something that [JDK-8303796](https://bugs.openjdk.org/browse/JDK-8303796) claimed to be a small enhancement is in fact requiring a lot of changes in different areas of the codebase. There are already a number of "duplicate symbol definition" issues that have been filed and fixed in an ad-hoc manner in the JDK, which is the kind of whack-a-mole approach that we should not be taking. If static linking requires symbol isolation then a generally applicable approach to doing that should be investigated (in a separate project? Leyden?) and then brought to mainline via a JEP (not just for the hotspot aspect as currently suggested).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14808#issuecomment-1635186576
More information about the hotspot-dev
mailing list