RFR: 8312077: Fix signed integer overflow, final part [v2]

Andrew Haley aph at openjdk.org
Fri Jul 14 08:43:20 UTC 2023


On Fri, 14 Jul 2023 08:38:40 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This is hopefully the last set of integer overflow fixes for hotspot.  Some of the counters I changed to unsigned are updated in platform-specific code, so I could use some help testing on arm, ppc,  riscv, and s390.
>
> Dean Long has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - windows build
>  - windows build

src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp line 557:

> 555:     }
> 556: 
> 557:     if (next_j <= sleep_to_next) {

It looks to me like this changes semantics so that it's now broken if `X_period_millis` wraps around. Do you actually want to change semantics in this case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14883#discussion_r1263467252


More information about the hotspot-dev mailing list