RFR: 8303134: JFR: Missing stack trace during chunk rotation stress [v9]

[Markus Grönlund]

On Thu, 13 Jul 2023 17:56:37 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> please help review this fix for some problematic situations in JFR where data can be lost. Most problems originate from writing event data in the wrong epoch due to safepointing. Detailed information about the changes is in the JIRA issue.
>> 
>> Testing: jdk_jfr, stress testing.
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove space
>   
>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8305:

> 8303:   }
> 8304: 
> 8305: #ifdef INCLUDE_JFR

Suggestion:

#if INCLUDE_JFR

src/hotspot/cpu/arm/stubGenerator_arm.cpp line 3162:

> 3160:   }
> 3161: 
> 3162: #ifdef INCLUDE_JFR

Suggestion:

#if INCLUDE_JFR

src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 4769:

> 4767:   }
> 4768: 
> 4769: #ifdef INCLUDE_JFR

Suggestion:

#if INCLUDE_JFR

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4052:

> 4050:   }
> 4051: 
> 4052: #ifdef INCLUDE_JFR

Suggestion:

#if INCLUDE_JFR

src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3146:

> 3144:   }
> 3145: 
> 3146: #ifdef INCLUDE_JFR

Suggestion:

#if INCLUDE_JFR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14761#discussion_r1263530276
PR Review Comment: https://git.openjdk.org/jdk/pull/14761#discussion_r1263529887
PR Review Comment: https://git.openjdk.org/jdk/pull/14761#discussion_r1263528987
PR Review Comment: https://git.openjdk.org/jdk/pull/14761#discussion_r1263528443
PR Review Comment: https://git.openjdk.org/jdk/pull/14761#discussion_r1263527754