RFR: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
Amit Kumar
amitkumar at openjdk.org
Fri Jul 14 13:31:16 UTC 2023
On Fri, 14 Jul 2023 12:44:03 GMT, sid8606 <duke at openjdk.org> wrote:
> All faults on s390x give the address only on page granularity.
> e.g. if you use 0x123456 as fail address you get si_addr == 0x123000
src/hotspot/share/utilities/vmError.hpp line 210:
> 208:
> 209: // Non-null address guaranteed to generate a SEGV mapping error on read, for test purposes.
> 210: static constexpr intptr_t segfault_address = AIX_ONLY(-1) NOT_AIX(4 * K);
Are we sure ARM & RISC-V will be happy with these changes, Maybe using `S390_ONLY` will be appropriate(?)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1263737821
More information about the hotspot-dev
mailing list