RFR: 8312190: Fix c++11-narrowing warnings in hotspot code

Kim Barrett kbarrett at openjdk.org
Tue Jul 18 08:11:03 UTC 2023


On Mon, 17 Jul 2023 18:31:41 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> This patch fixes compilation warnings produced by Clang when compiling on Windows.
> 
> Clang emulates MSVC behavior and uses `int` for enumeration types that do not explicitly specify the underlying type. This patch sets an explicit underlying type for 3 enumerations to fix the warnings.
> 
> See Microsoft's documentation of [Zc:enumTypes](https://learn.microsoft.com/en-us/cpp/build/reference/zc-enumtypes?view=msvc-170) for more information.

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14907#pullrequestreview-1534451544


More information about the hotspot-dev mailing list