RFR: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure [v6]

Amit Kumar amitkumar at openjdk.org
Wed Jul 19 06:08:45 UTC 2023


On Wed, 19 Jul 2023 06:01:08 GMT, sid8606 <duke at openjdk.org> wrote:

>> All faults on s390x give the address only on page granularity.
>> e.g. if you use 0x123456 as fail address you get si_addr = 0x123000
>
> sid8606 has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add a space
>  - Fix typo

src/hotspot/cpu/s390/globalDefinitions_s390.hpp line 34:

> 32: 
> 33: // All faults on s390x give the address only on page granularity.
> 34: // Set Pdsegfault_address to miniumum one page address.

Suggestion:

// Set Pdsegfault_address to minimum one page address.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1267579828


More information about the hotspot-dev mailing list