RFR: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure [v9]

[Tyler Steele]

On Wed, 19 Jul 2023 13:41:59 GMT, sid8606 <duke at openjdk.org> wrote:

>> All faults on s390x give the address only on page granularity.
>> e.g. if you use 0x123456 as fail address you get si_addr = 0x123000
>
> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add AIX pd_segfault_address to -1 on zero build

Marked as reviewed by tsteele (Committer).

Ran it on AIX just to be sure, and the test still passes. I have noted one cosmetic suggestion. LGTM 😄

Ha. I guess I should have refreshed the page before sending my review & comment.

src/hotspot/cpu/zero/globalDefinitions_zero.hpp line 45:

> 43: const size_t pd_segfault_address = 4096;
> 44: #else
> 45: const size_t pd_segfault_address = 1024;

Format police! I find it's a bit more readable to indent the non-macro lines.


#if defined(AIX)
  const size_t pd_segfault_address = -1;
#elif ...

-------------

PR Review: https://git.openjdk.org/jdk/pull/14888#pullrequestreview-1537587323
PR Comment: https://git.openjdk.org/jdk/pull/14888#issuecomment-1642581574
PR Comment: https://git.openjdk.org/jdk/pull/14888#issuecomment-1642582731
PR Review Comment: https://git.openjdk.org/jdk/pull/14888#discussion_r1268385859