RFR: JDK-8312395: Improve assertions in growableArray

[David Holmes]

On Thu, 20 Jul 2023 07:43:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There are a number of assertions in growableArray , for example to check for a valid index to access/remove elements.
> Those assertions can be improved, e.g. by showing the bad index value used in case of failure.
> 
> Example for an assertion in the 'at(index i)' access method 
> old assertion looks like
> assert(0 <= i && i < _len) failed: illegal index
> 
> new assertion looks like
> assert(0 <= i && i < _len) failed: illegal index -559030609, 1 accessible elements

Approval in principle but I have a suggestion.

Thanks

src/hotspot/share/utilities/growableArray.hpp line 145:

> 143: 
> 144:   E& at(int i) {
> 145:     assert(0 <= i && i < _len, "illegal index %d, %d accessible elements", i, _len);

How about:

"Illegal index %d for length %d"

?

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14946#pullrequestreview-1538665870
PR Review Comment: https://git.openjdk.org/jdk/pull/14946#discussion_r1269080964