RFR: 8311130: AArch64: Sync SVE related CPU features with VM options [v3]

Xiaohong Gong xgong at openjdk.org
Thu Jul 20 09:25:44 UTC 2023


On Thu, 20 Jul 2023 04:01:07 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> As discussed in PR #14533, keeping AArch64 flag `UseSVE` and its related CPU features in sync helps to simplify rules in IR tests. In this patch, we mask SVE related CPU features off if specified SVE level in VM option is lower than the hardware supported. Also, to support this change, we move the features string construction to the end of the `initialize()` function.
>> 
>> We also revert IR rule changes in PR #14533 and fix some code styles. We tested almost full jtreg on SVE, SVE2 and non-SVE CPUs and no new issue is found after this patch.
>
> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix dangling else

LGTM! Thanks for the fix!

-------------

Marked as reviewed by xgong (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14897#pullrequestreview-1538836197


More information about the hotspot-dev mailing list