RFR: JDK-8312395: Improve assertions in growableArray [v3]
Matthias Baesken
mbaesken at openjdk.org
Thu Jul 20 15:10:07 UTC 2023
On Thu, 20 Jul 2023 12:04:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> There are a number of assertions in growableArray , for example to check for a valid index to access/remove elements.
>> Those assertions can be improved, e.g. by showing the bad index value used in case of failure.
>>
>> Example for an assertion in the 'at(index i)' access method
>> old assertion looks like
>> assert(0 <= i && i < _len) failed: illegal index
>>
>> new assertion looks like
>> assert(0 <= i && i < _len) failed: illegal index -559030609, 1 accessible elements
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> improve assert in remove_range
Hi David and Thomas, thanks for the reviews !
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14946#issuecomment-1644096824
More information about the hotspot-dev
mailing list